Remove Get-ErrorDetail function

vreguibar · Oct 8, 2024 · 5af45c6 · 5af45c6
1 parent 94bf0ef
commit 5af45c6
Show file tree

Hide file tree

Showing 23 changed files with 66 additions and 65 deletions.
diff --git a/Private/Convert-SidToName.ps1 b/Private/Convert-SidToName.ps1
@@ -88,7 +88,7 @@
 
         } catch {
             Write-Error -Message ('An unexpected error occurred: {0}' -f $_)
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             $FoundName = $null
             throw
         }#end Try-Catch

diff --git a/Private/ConvertTo-AccountName.ps1 b/Private/ConvertTo-AccountName.ps1
@@ -86,12 +86,14 @@
             } #end If-Else
 
         } catch {
-            Write-Warning -Message ('
-                Failed to convert SID: {0} to account name.
-                This account should not be processed further.' -f
-                $PSBoundParameters['SID']
-            )
-            Get-ErrorDetail -ErrorRecord $_
+            $txt = [System.Text.StringBuilder]::new()
+            [void]$txt.AppendLine($Constants.NL)
+            [void]$txt.AppendLine('Failed to convert SID: { 0 } to account name.' -f $PSBoundParameters['SID'])
+            [void]$txt.AppendLine('This account might not be processed further.')
+            [void]$txt.AppendLine($Constants.NL)
+
+            Write-Warning -Message $txt
+            ##Get-ErrorDetail -ErrorRecord $_
             return $null
         } #end Try-Catch
 

diff --git a/Private/ConvertTo-SID.ps1 b/Private/ConvertTo-SID.ps1
@@ -63,7 +63,7 @@
 
         } catch {
             Write-Error -Message ('Failed to convert {0} to SID. Error: {1}' -f $AccountName, $_.Exception.Message)
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             return $null
         } #end Try-Catch
     } #end Process

diff --git a/Private/Get-AdWellKnownSID.ps1 b/Private/Get-AdWellKnownSID.ps1
@@ -84,7 +84,7 @@
             Write-Verbose -Message ('  Description: {0}' -f $sidDescription)
         } catch {
             Write-Error -Message 'Error when checking WellKnownSid'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 

diff --git a/Private/Get-GptTemplate.ps1 b/Private/Get-GptTemplate.ps1
@@ -79,7 +79,7 @@ function Get-GptTemplate {
                         Error while trying to create the folder for {0}' -f
                         $gpo.DisplayName
                     )
-                    Get-ErrorDetail -ErrorRecord $_
+                    #Get-ErrorDetail -ErrorRecord $_
                 } #end Try-Catch
 
             } #end if
@@ -95,7 +95,7 @@ function Get-GptTemplate {
                         Error while trying to create GptTmpl.inf file within folder for {0}' -f
                         $gpo.DisplayName
                     )
-                    Get-ErrorDetail -ErrorRecord $_
+                    #Get-ErrorDetail -ErrorRecord $_
                 } #end Try-Catch
 
             } #end if
@@ -116,7 +116,7 @@ function Get-GptTemplate {
 
         } catch {
             Write-Error -Message ('An error occurred while handling the GPT template path.')
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             return $null
         } #end Try-Catch
 

diff --git a/Private/Set-AclConstructor4.ps1 b/Private/Set-AclConstructor4.ps1
@@ -206,7 +206,7 @@ function Set-AclConstructor4 {
 
         } Catch {
             Write-Error -Message ('Error while trying to access LDAP object {0}' -f $PSBoundParameters['LDAPPath'])
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -219,7 +219,7 @@ function Set-AclConstructor4 {
 
         } Catch {
             Write-Error -Message ('Error while trying to Get a copy of the current DACL {0}' -f $object.DistinguishedName)
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -278,7 +278,7 @@ function Set-AclConstructor4 {
 
         } Catch {
             Write-Error -Message ('Error when trying to re-apply the modified DACL to the {0}' -f $objectDN.DistinguishedName)
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
     } #end Process

diff --git a/Private/Set-AclConstructor5.ps1 b/Private/Set-AclConstructor5.ps1
@@ -226,7 +226,7 @@ function Set-AclConstructor5 {
 
         } Catch {
             Write-Error -Message ('Error while trying to access LDAP object {0}' -f $PSBoundParameters['LDAPPath'])
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -239,7 +239,7 @@ function Set-AclConstructor5 {
 
         } Catch {
             Write-Error -Message ('Error while trying to Get a copy of the current DACL {0}' -f $object.DistinguishedName)
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -302,7 +302,7 @@ function Set-AclConstructor5 {
 
         } Catch {
             Write-Error -Message ('Error when trying to re-apply the modified DACL to the {0}' -f $objectDN.DistinguishedName)
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 

diff --git a/Private/Set-AclConstructor6.ps1 b/Private/Set-AclConstructor6.ps1
@@ -243,7 +243,7 @@ function Set-AclConstructor6 {
 
         } Catch {
             Write-Error -Message ('Error while trying to access LDAP object {0}' -f $PSBoundParameters['LDAPPath'])
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -256,7 +256,7 @@ function Set-AclConstructor6 {
 
         } Catch {
             Write-Error -Message ('Error while trying to Get a copy of the current DACL {0}' -f $object.DistinguishedName)
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -322,7 +322,7 @@ function Set-AclConstructor6 {
 
         } Catch {
             Write-Error -Message ('Error when trying to re-apply the modified DACL to the {0}' -f $objectDN.DistinguishedName)
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
     } #end Process

diff --git a/Private/Set-GPOConfigSection.ps1 b/Private/Set-GPOConfigSection.ps1
@@ -171,7 +171,7 @@
                             [void]$txt.AppendLine('Item might not be added to the corresponding section. Please verify it!')
                             [void]$txt.AppendLine($Constants.NL)
                             Write-Warning -Message $txt
-                            #Get-ErrorDetail -ErrorRecord $_
+                            ##Get-ErrorDetail -ErrorRecord $_
                         } #end Try-Catch
 
                         if ($resolvedAccount) {
@@ -233,7 +233,7 @@
                             [void]$txt.AppendLine('Item might not be added to the corresponding section. Please verify it!')
                             [void]$txt.AppendLine($Constants.NL)
                             Write-Warning -Message $txt
-                            #Get-ErrorDetail -ErrorRecord $_
+                            ##Get-ErrorDetail -ErrorRecord $_
                         } #end If-Else
 
                     } #end If
@@ -283,7 +283,7 @@
                 {2}' -f
                 $CurrentKey, $CurrentSection, $_
             )
-            #Get-ErrorDetail -ErrorRecord $_
+            ##Get-ErrorDetail -ErrorRecord $_
         } #end Try-Catch
     } #end Process
 

diff --git a/Private/Test-IsValidDN.ps1 b/Private/Test-IsValidDN.ps1
@@ -72,7 +72,7 @@
         } catch {
             # Handle exceptions gracefully
             Write-Error -Message 'Error when validating DistinguishedName'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
         } #end Try-Catch
 
     } #end Process

diff --git a/Private/Test-IsValidGUID.ps1 b/Private/Test-IsValidGUID.ps1
@@ -74,7 +74,7 @@
         } catch {
             # Handle exceptions gracefully
             Write-Error -Message 'Error when validating GUID'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
         } #end Try-Catch
 
     } #end Process

diff --git a/Private/Test-IsValidSID.ps1 b/Private/Test-IsValidSID.ps1
@@ -62,32 +62,28 @@
     Process {
         # try RegEx
         Try {
-            # Provide verbose output
-            if ($PSCmdlet.MyInvocation.BoundParameters['Verbose']) {
-
-                #if ($Variables.WellKnownSIDs -Contains $ObjectSID) {
-                If ($Variables.WellKnownSIDs.Keys.Contains($ObjectSID)) {
 
-                    Write-Verbose -Message ('The SID {0} is a WellKnownSid.' -f $ObjectSID)
-                    $isValid = $true
+            #if ($Variables.WellKnownSIDs -Contains $ObjectSID) {
+            If ($Variables.WellKnownSIDs.Keys.Contains($ObjectSID)) {
 
-                } elseIf ($ObjectSID -match $Constants.SidRegEx) {
+                Write-Verbose -Message ('The SID {0} is a WellKnownSid.' -f $ObjectSID)
+                $isValid = $true
 
-                    Write-Verbose -Message ('The SID {0} is valid.' -f $ObjectSID)
-                    $isValid = $true
+            } elseIf ($ObjectSID -match $Constants.SidRegEx) {
 
-                } else {
+                Write-Verbose -Message ('The SID {0} is valid.' -f $ObjectSID)
+                $isValid = $true
 
-                    Write-Verbose -Message ('[WARNING] The SID {0} is NOT valid!.' -f $ObjectSID)
-                    $isValid = $false
+            } else {
 
-                } #end If-Else
+                Write-Verbose -Message ('[WARNING] The SID {0} is NOT valid!.' -f $ObjectSID)
+                $isValid = $false
 
-            } #end If VERBOSE
+            } #end If-Else
         } catch {
             # Handle exceptions gracefully
             Write-Error -Message ('An error occurred when validating the SID: {0}' -f $_)
-            Get-ErrorDetail -ErrorRecord $_
+            ##Get-ErrorDetail -ErrorRecord $_
         } #end Try-Catch
 
         <#

diff --git a/Private/Test-NameIsWellKnownSid.ps1 b/Private/Test-NameIsWellKnownSid.ps1
@@ -86,7 +86,7 @@
                         Error creating SecurityIdentifier object for {0}.' -f
                         $cleanName
                     )
-                    #Get-ErrorDetail -ErrorRecord $_
+                    ##Get-ErrorDetail -ErrorRecord $_
                     $Identity = $null
                 }
             } else {
@@ -100,7 +100,7 @@
         } catch {
             Write-Error -Message ('Error found when translating WellKnownSid for {0}.' -f $cleanedName)
             $Identity = $null
-            #Get-ErrorDetail -ErrorRecord $_
+            ##Get-ErrorDetail -ErrorRecord $_
         } #end Try-Catch
 
     } #end Process

diff --git a/Private/Update-GpoVersion.ps1 b/Private/Update-GpoVersion.ps1
@@ -71,7 +71,7 @@ function Update-GpoVersion {
         } catch {
 
             Write-Error -Message ('Error accessing GPO through DirectoryEntry' -f $Gpo.Name)
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
 
         } #end Try-Catch
 
@@ -152,7 +152,7 @@ function Update-GpoVersion {
                 } #end If
             } #end If
         } catch {
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw "The GPTs.ini file could not be modified: $_. Message is $($_.Exception.Message)"
         } #end Try-Catch
 

diff --git a/Public/AdTopology/Set-AdAclCreateDeleteSite.ps1 b/Public/AdTopology/Set-AdAclCreateDeleteSite.ps1
@@ -124,7 +124,7 @@
             }
         } Catch {
             Write-Error -Message 'Error when delegating Create/Delete site'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -164,7 +164,7 @@
             }
         } Catch {
             Write-Error -Message 'Error when delegating Create/Delete site'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -205,7 +205,7 @@
             }
         } Catch {
             Write-Error -Message 'Error when delegating Create/Delete site'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -245,7 +245,7 @@
             }
         } Catch {
             Write-Error -Message 'Error when delegating Create/Delete site'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -283,7 +283,7 @@
             }
         } Catch {
             Write-Error -Message 'Error when delegating Create/Delete site'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -323,7 +323,7 @@
             }
         } Catch {
             Write-Error -Message 'Error when delegating Create/Delete site'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -364,7 +364,7 @@
             }
         } Catch {
             Write-Error -Message 'Error when delegating Create/Delete site'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -405,7 +405,7 @@
             }
         } Catch {
             Write-Error -Message 'Error when delegating Create/Delete site'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 
@@ -444,7 +444,7 @@
             }
         } Catch {
             Write-Error -Message 'Error when delegating Create/Delete site'
-            Get-ErrorDetail -ErrorRecord $_
+            #Get-ErrorDetail -ErrorRecord $_
             throw
         } #end Try-Catch
 

diff --git a/Public/GPO/Set-GpoPrivilegeRight.ps1 b/Public/GPO/Set-GpoPrivilegeRight.ps1
@@ -630,6 +630,9 @@
                 $Key,
 
                 [Parameter(Mandatory = $true)]
+                [AllowNull()]
+                [AllowEmptyString()]
+                [AllowEmptyCollection()]
                 [System.Collections.Generic.List[object]]
                 $Members
             )
@@ -1185,7 +1188,7 @@
 
                 } Catch {
                     Write-Error -Message ('Something went wrong. {0}' -f $_)
-                    #Get-ErrorDetail -ErrorRecord $_
+                    ##Get-ErrorDetail -ErrorRecord $_
                 } #end Try-Catch
 
             } #end If
@@ -1199,7 +1202,7 @@
 
         } Catch {
             Write-Error -Message ('Something went wrong while trying to save the GptTmpl.inf file...')
-            #Get-ErrorDetail -ErrorRecord $_
+            ##Get-ErrorDetail -ErrorRecord $_
             Throw
         }
 

diff --git a/Public/Logging/Write-CustomLog.ps1 b/Public/Logging/Write-CustomLog.ps1
@@ -309,7 +309,7 @@
                     Full details: {1}' -f
                     $_.Exception.Message, $_
                 )
-                Get-ErrorDetail -ErrorRecord $_
+                #Get-ErrorDetail -ErrorRecord $_
                 throw
             } #end Try-Catch
         } #end If