Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom directive v2 #278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: custom directive v2 #278

wants to merge 1 commit into from

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Sep 19, 2024

Simplify custom directive API to match the template ref API.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit ef8c4f6
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/66ec0aef82844e0008cbb242
😎 Deploy Preview https://deploy-preview-278--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit ef8c4f6
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/66ec0aef2aab5b0008fbd035
😎 Deploy Preview https://deploy-preview-278--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81.9 kB 28.5 kB 25.1 kB
compiler-vapor.global.prod.js 59 kB 19.7 kB 17.8 kB
runtime-dom.global.prod.js 101 kB 37.9 kB 34 kB
runtime-vapor.global.prod.js 47.3 kB (+1.87 kB) 17.8 kB (+804 B) 16.2 kB (+717 B)
vue-vapor.global.prod.js 103 kB (+1.87 kB) 35.8 kB (+774 B) 32.3 kB (+642 B)
vue.global.prod.js 159 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.2 kB 18.9 kB 17.3 kB
createApp 55.8 kB 21.4 kB 19.6 kB
createSSRApp 59.8 kB 23.1 kB 21 kB
defineCustomElement 60.6 kB 22.9 kB 20.9 kB
vapor 47.9 kB (+1.87 kB) 18 kB (+797 B) 16.4 kB (+720 B)
overall 69.5 kB 26.5 kB 24.1 kB

@LittleSound
Copy link
Member

Great. I had this idea before. Thanks for starting it

can you explain how this API behaves differently from before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants