Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cache into standalone app #200

Merged
merged 5 commits into from
Feb 22, 2019
Merged

Added cache into standalone app #200

merged 5 commits into from
Feb 22, 2019

Conversation

syrusakbary
Copy link
Member

Added cache into standalone app.
This PR also removes wasm_hash from the ModuleInfo to use it directly with the cache api (load/store).

bjfish
bjfish reviewed Feb 22, 2019
View reviewed changes
Copy link
Contributor

@bjfish bjfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be an option to disable cache? I think it would be nice if integration tests ran for uncached, then cached.

@lachlansneff
Copy link
Contributor

Should there be an option to disable cache? I think it would be nice if integration tests ran for uncached, then cached.

@bjfish Good idea, cli flag?

@syrusakbary
Copy link
Member Author

@bjfish @lachlansneff I've just added an option --disable-cache in the CLI for wasmer run.
So we can do wasmer run examples/lua.wasm --disable-cache -- -V

@syrusakbary syrusakbary merged commit 9b32a6c into master Feb 22, 2019
@syrusakbary syrusakbary mentioned this pull request Feb 22, 2019
Closed
@syrusakbary syrusakbary deleted the feature/standalone-cache branch March 4, 2019 15:46
nlewycky pushed a commit that referenced this pull request Aug 13, 2020
@MarkMcCaskey
Merge pull request #200 from wasmerio/feature/clean-up-cargo-tomls
eda22fc 
Add misc clean ups to `Cargo.toml`s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjfish bjfish bjfish left review comments

@xmclark xmclark xmclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syrusakbary @lachlansneff @bjfish @xmclark