Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflow for running tests #28

Merged
merged 60 commits into from
Nov 13, 2023
Merged

Add CI workflow for running tests #28

merged 60 commits into from
Nov 13, 2023

Conversation

BENJIGAO
Copy link
Contributor

@BENJIGAO BENJIGAO commented Dec 30, 2022 •
edited
Loading

CLICKUP TICKET LINK

Add CI workflow that runs unit tests whenever a PR is created and/or commits are pushed to any PRs
Make testing use node_modules instead of yarn

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Ran the CI workflow on this PR, and the latest run passed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation/READ-ME/UMLS (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@jennchenn
Copy link

Task linked: CU-2u4qk1u Run CMS unit tests every time a PR is made

@BENJIGAO BENJIGAO marked this pull request as ready for review January 3, 2023 23:43
@BENJIGAO BENJIGAO changed the title Add CI/CD workflow for running tests Add CI workflow for running tests Jan 3, 2023
@BENJIGAO BENJIGAO self-assigned this Jan 3, 2023
@BENJIGAO BENJIGAO added the enhancement New feature or request label Jan 3, 2023
@BENJIGAO
Copy link
Contributor Author

BENJIGAO commented Jan 3, 2023

Originally there were integration tests in the workflow, but it caused errors regarding exit code 9's and the integration tests failing, as shown here: https://github.com/waterloop/waterloop-cms/actions/runs/3833792269/jobs/6525575898. I couldn't figure out a workaround, so I'm sticking to just unit tests for now, which is what the ticket asked for

@jmawloo
Copy link
Member

jmawloo commented Jan 12, 2023 •
edited
Loading

@BENJIGAO github-actions is working as expected; the integration test for blog post routes is failing for some reason. We're gonna need a ticket to fix it.

Since u're the project lead for CMS, u mind creating that ticket? Thanks :)

@BENJIGAO
Copy link
Contributor Author

For sure, I'll create it and other tickets for the CMS as well. Can we review/approve this PR for now?

jmawloo
jmawloo reviewed Jan 12, 2023
View reviewed changes
.yarnrc.yml Outdated
@@ -5,3 +5,4 @@ plugins:
spec: "@yarnpkg/plugin-interactive-tools"

yarnPath: .yarn/releases/yarn-3.3.0.cjs
nodeLinker: node-modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Srry another thing I wanted to check is if we can use GitHub actions to add this line to the file, rather than committing it with this line.

I searched it up and found some possible solutions yesterday, however I haven't found anything too concrete yet.

Just wanna make sure we don't introduce broken dependencies for pnp.js in the future

Jeff Ma and others added 8 commits January 21, 2023 13:26
Updated README.md
4f9e371
Updated README.md
6d6af0d
Merge branch 'main' of github.com:waterloop/waterloop-cms
fa590d1
Update README.md
0635986
Update README.md (#31)
5783dbb
@Samanthatb1
fixed postings integration test
948248a
@Samanthatb1
Merge pull request #35 from waterloop/CU-860pjn743/Fix-integration-te…
24f1384 
…st-issue-with-Postings-ID--other-downstream-errors

Fix integration test issue with Postings ID
@klau1011
Fix CMS edit goose save functionality (#37)
7708f7e 
* fixed geese edit info to actually save, bugs remain

* fixed bugs, form now correctly  updates on save

* cleaned up code

* updated redudant code, according to PR comments

* cleaned up code, removed unneeded commented out blocks of code

* fixed ability to save new goose

* typo fix
klau1011 and others added 26 commits July 7, 2023 17:30
@klau1011
Merge branch 'main' of github.com:waterloop/waterloop-cms
d6d5a61 
g the commit.
@klau1011
initialized products api endpoint and getters
9cf8fc0
@klau1011
add,del product api endpoints
19cd12f
@klau1011
fixed updateProductByID error
d28e21a
@klau1011
update api endpoint
bab44ec
@aayush3416
added variation endpoints
8552e7d
@klau1011
merch store API variations
7e13561
@klau1011
fixes
2f49ade
@klau1011
Remove file
e4452b9
@klau1011
revert changes from other ticket
39822b2
@klau1011
added validation
24852bd
@klau1011
rm git yarnrc file
4b95038
@klau1011
reverted readme
3dcf41c
@klau1011
minor fixes
318c755
@klau1011
validation added back in after testing
e5f9185
@aayush3416
Merge pull request #44 from waterloop/merch-store-api-endpoints
0670512 
Merch store api endpoints
@klau1011
Merge branch 'CU-2u4qk1u' of github.com:waterloop/waterloop-cms
a15e3ce
@klau1011
Update main.yaml
9c7bfcd
@klau1011
Update main.yaml
96072a8
@klau1011
remove hardcoded nodelinkers
ec59109
@klau1011
remove hardcoded nodelinkers
6fed819
@klau1011
Removed failing unit test for action tests
d4aa9f9
@klau1011
Remove broken tests
dac92c5
@klau1011
Add integration tests to CI
cf0eb67
@klau1011
Update main.yaml
24faa69
@klau1011
Remove broken integration tests
5ae2725
@klau1011 klau1011 self-assigned this Nov 13, 2023
@klau1011 klau1011 merged commit 549bd16 into main Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmawloo jmawloo jmawloo left review comments

@aayush3416 aayush3416 aayush3416 approved these changes

@SteveShengStar SteveShengStar Awaiting requested review from SteveShengStar

@LavanSumanan LavanSumanan Awaiting requested review from LavanSumanan

@sashco-m sashco-m Awaiting requested review from sashco-m

Assignees

@BENJIGAO BENJIGAO

@klau1011 klau1011

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BENJIGAO @jennchenn @jmawloo @aayush3416 @klau1011 @Samanthatb1 @tahazaryab