Add Support for Nethermind and Besu 'syncing' Subscription Payload Fo…

…rmat (#7306) * Add Support for Nethermind and Besu 'syncing' Subscription Payload Formats * Add CHANGELOG note for PR7306
web3 · Oct 7, 2024 · 9edb183 · 9edb183 · github-actions · Oct 7, 2024
1 parent 496ed93
commit 9edb183
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2729,6 +2729,12 @@ If there are any bugs, improvements, optimizations or any new feature proposal f
 
 ## [Unreleased]
 
+### Added
+
+#### web3-eth
+
+-   `syncing` subscription now supports Besu and Nethermind payload format
+
 ### Changed
 
 #### web3-eth

diff --git a/packages/web3-eth/src/web3_subscriptions.ts b/packages/web3-eth/src/web3_subscriptions.ts
@@ -163,7 +163,7 @@ export class SyncingSubscription extends Web3Subscription<{
 			this.emit('changed', data);
 		} else {
 			const mappedData: SyncOutput = Object.fromEntries(
-				Object.entries(data.status).map(([key, value]) => [
+				Object.entries(data?.status || data).map(([key, value]) => [
 					key.charAt(0).toLowerCase() + key.substring(1),
 					value,
 				]),
Benchmark suite	Current: `9edb183`	Previous: `496ed93`	Ratio
`processingTx`	`20759` ops/sec (`±6.90%`)	`23151` ops/sec (`±7.53%`)	`1.12`
`processingContractDeploy`	`34761` ops/sec (`±8.29%`)	`40757` ops/sec (`±6.82%`)	`1.17`
`processingContractMethodSend`	`14207` ops/sec (`±8.42%`)	`16564` ops/sec (`±6.72%`)	`1.17`
`processingContractMethodCall`	`25181` ops/sec (`±6.62%`)	`27653` ops/sec (`±7.43%`)	`1.10`
`abiEncode`	`38299` ops/sec (`±7.93%`)	`45773` ops/sec (`±6.82%`)	`1.20`
`abiDecode`	`26613` ops/sec (`±7.51%`)	`31264` ops/sec (`±7.04%`)	`1.17`
`sign`	`1525` ops/sec (`±1.03%`)	`1580` ops/sec (`±0.97%`)	`1.04`
`verify`	`349` ops/sec (`±0.51%`)	`366` ops/sec (`±0.98%`)	`1.05`