Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gas Estimation Guide #7319

Merged
merged 8 commits into from
Oct 11, 2024
Merged

Add Gas Estimation Guide #7319

merged 8 commits into from
Oct 11, 2024

Conversation

danforbes
Copy link
Contributor

Closes #7299

Copy link

github-actions bot commented Oct 9, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.83 kB 0%
Changeset
File Δ Size
../web3-eth/lib/commonjs/web3_eth.js 📈 +530 B (+0.57%) 90.77 kB → 91.29 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 621.34 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 148 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d4abafb Previous: f701406 Ratio
processingTx 21202 ops/sec (±7.78%) 22830 ops/sec (±7.43%) 1.08
processingContractDeploy 37309 ops/sec (±6.28%) 39939 ops/sec (±7.35%) 1.07
processingContractMethodSend 14624 ops/sec (±9.64%) 15792 ops/sec (±6.76%) 1.08
processingContractMethodCall 26543 ops/sec (±5.83%) 27711 ops/sec (±6.25%) 1.04
abiEncode 41231 ops/sec (±6.99%) 42219 ops/sec (±7.33%) 1.02
abiDecode 29259 ops/sec (±6.42%) 29744 ops/sec (±7.55%) 1.02
sign 1505 ops/sec (±1.22%) 1498 ops/sec (±3.49%) 1.00
verify 354 ops/sec (±0.76%) 365 ops/sec (±0.60%) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (f701406) to head (d4abafb).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7319   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files         216      216           
  Lines        8463     8463           
  Branches     2340     2340           
=======================================
  Hits         7993     7993           
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@krzysu krzysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, a good read! 👍 I’ve left a few suggestions for improvement.

danforbes and others added 2 commits October 11, 2024 10:07
Co-authored-by: Kris <605420+krzysu@users.noreply.github.com>
Co-authored-by: Alex  <luu.alex98@gmail.com>
Co-authored-by: Kris <605420+krzysu@users.noreply.github.com>
@danforbes danforbes merged commit bbde6ea into 4.x Oct 11, 2024
54 checks passed
@danforbes danforbes deleted the feat/docs/gas-estimation branch October 11, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new Guide about Gas Estimation
4 participants