Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignoregaspricing config #7320

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Oct 11, 2024

Description

Fixes #7303
adds ignoregaspricing so contracts or sending transactions through web3.eth will not be autofill gas.

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.83 kB → 641.05 kB (+225 B) +0.03%
Changeset
File Δ Size
../web3-core/lib/commonjs/web3_config.js 📈 +497 B (+2.86%) 16.96 kB → 17.44 kB
../web3-eth/lib/commonjs/utils/send_tx_helper.js 📈 +61 B (+0.66%) 9.03 kB → 9.09 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 621.34 kB → 621.56 kB (+225 B) +0.04%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 148 B 0%
../lib/commonjs/version.d.ts 60 B 0%

@luu-alex luu-alex marked this pull request as ready for review October 11, 2024 02:55
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d05b9cb Previous: f701406 Ratio
processingTx 23025 ops/sec (±8.04%) 22830 ops/sec (±7.43%) 0.99
processingContractDeploy 40784 ops/sec (±7.01%) 39939 ops/sec (±7.35%) 0.98
processingContractMethodSend 16915 ops/sec (±6.65%) 15792 ops/sec (±6.76%) 0.93
processingContractMethodCall 27756 ops/sec (±7.59%) 27711 ops/sec (±6.25%) 1.00
abiEncode 46346 ops/sec (±6.44%) 42219 ops/sec (±7.33%) 0.91
abiDecode 30495 ops/sec (±7.09%) 29744 ops/sec (±7.55%) 0.98
sign 1574 ops/sec (±0.93%) 1498 ops/sec (±3.49%) 0.95
verify 368 ops/sec (±0.61%) 365 ops/sec (±0.60%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (f701406) to head (d05b9cb).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7320   +/-   ##
=======================================
  Coverage   94.44%   94.45%           
=======================================
  Files         216      216           
  Lines        8463     8469    +6     
  Branches     2340     2341    +1     
=======================================
+ Hits         7993     7999    +6     
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex
Copy link
Contributor Author

will also update docs + changelog

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luu-alex Also add e2e/integration test in web3 package for testing eth and contract package with ignore gas pricing true and false. plus in this PR need to add in docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot prevent site suggested gas price in Metamask
4 participants