Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactor for git internal pack decode #27

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Code refactor for git internal pack decode #27

merged 1 commit into from
Jun 28, 2023

Conversation

Ivanbeethoven
Copy link
Contributor

📜TODO:

  1. Change the ObjectT Structs 's attribute "raw_data" from the Vec<u8> to Option<Vec<u8>> .
  2. More UTest. Bigger Pack file.
  3. Multi Pack Decode.

❔Problem:

  1. The ObjReader and the DeltaReader need to further design.Currently, it has not utilized DeltaReader's asynchronous feature
  2. The cache size is worth further discussion.

@genedna genedna enabled auto-merge June 28, 2023 10:58
@Ivanbeethoven
Code refactor for git internal pack decode
d3112f7 
Signed-off-by: Xiaoyang Han <lux1an@qq.com>
auto-merge was automatically disabled June 28, 2023 11:27

Head branch was pushed to by a user without write access

@genedna genedna enabled auto-merge June 28, 2023 12:14
@genedna genedna added this pull request to the merge queue Jun 28, 2023
Merged via the queue into web3infra-foundation:main with commit 0804174 Jun 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genedna genedna genedna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivanbeethoven @genedna