[HOTFIX] Do not flush any change to attribute config to avoid potenti…

…al MySQL error irreversible
webgriffe · Mar 6, 2024 · 2df2a42 · 2df2a42
1 parent 0d180d9
commit 2df2a42
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 23 deletions.
diff --git a/src/AttributeOptions/Importer.php b/src/AttributeOptions/Importer.php
@@ -338,12 +338,4 @@ private function getAkeneoPimClient(): AkeneoPimClientInterface
     {
         return $this->apiClient;
     }
-
-    /**
-     * @return RepositoryInterface<ProductAttributeInterface>
-     */
-    private function getAttributeRepository(): RepositoryInterface
-    {
-        return $this->attributeRepository;
-    }
 }
diff --git a/src/ProductAttributeHelperTrait.php b/src/ProductAttributeHelperTrait.php
@@ -7,7 +7,6 @@
 use Akeneo\Pim\ApiClient\AkeneoPimClientInterface;
 use Akeneo\Pim\ApiClient\Pagination\ResourceCursorInterface;
 use Sylius\Component\Product\Model\ProductAttributeInterface;
-use Sylius\Component\Resource\Repository\RepositoryInterface;
 
 /**
  * @psalm-type AkeneoAttributeOption array{_links: array, code: string, attribute: string, sort_order: int, labels: array<string, ?string>}
@@ -16,11 +15,6 @@ trait ProductAttributeHelperTrait
 {
     abstract private function getAkeneoPimClient(): AkeneoPimClientInterface;
 
-    /**
-     * @return RepositoryInterface<ProductAttributeInterface>
-     */
-    abstract private function getAttributeRepository(): RepositoryInterface;
-
     private function importAttributeConfiguration(string $attributeCode, ProductAttributeInterface $attribute): void
     {
         /** @var array{choices: array<string, array<string, string>>, multiple: bool, min: ?int, max: ?int} $configuration */
@@ -30,7 +24,7 @@ private function importAttributeConfiguration(string $attributeCode, ProductAttr
         );
         $attribute->setConfiguration($configuration);
 
-        $this->getAttributeRepository()->add($attribute);
+        // Do not flush any change here, otherwise we will cause a potential MySQL error irreversible.
     }
 
     /**

diff --git a/src/ValueHandler/AttributeValueHandler.php b/src/ValueHandler/AttributeValueHandler.php
@@ -185,12 +185,4 @@ private function getAkeneoPimClient(): AkeneoPimClientInterface
 
         return $akeneoPimClient;
     }
-
-    /**
-     * @return RepositoryInterface<ProductAttributeInterface>
-     */
-    private function getAttributeRepository(): RepositoryInterface
-    {
-        return $this->attributeRepository;
-    }
 }