Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Do not add product translation entity for locale not used in any channels of the product #137

Closed
lruozzi9 opened this issue Jul 13, 2022 · 1 comment · Fixed by #169
Closed

[BUG] - Do not add product translation entity for locale not used in any channels of the product #137

lruozzi9 opened this issue Jul 13, 2022 · 1 comment · Fixed by #169
Assignees
@mmenozzi
Labels
bug Something isn't working
Milestone
v2.0

Comments

@lruozzi9
Copy link
Member

Describe the bug
If you have an Akeneo product with one attribute handled by the TranslatablePropertyValueHandler different from the name in a language without the name attribute translated in that locale you get an error due to the not nullable name property on ProductTranslation. I'm not sure this is a "real bug", why do you have an attribute translated in a locale but not the name of the product? Anyway, I think the right solution to this problem, in my case, could be to check if the locale is used in at least one of the channels for the products, if not we can skip it.
@lruozzi9 lruozzi9 added the bug Something isn't working label Jul 13, 2022
lruozzi9 added a commit that referenced this issue Jul 13, 2022
@lruozzi9
Skip locales not used in any product channels (#137)
2995d0a
@lruozzi9 lruozzi9 mentioned this issue Jul 13, 2022
Merged
lruozzi9 added a commit that referenced this issue Jul 13, 2022
@lruozzi9
Skip locales not used in any product channels (#137)
847cde7
lruozzi9 added a commit that referenced this issue Aug 3, 2022
@lruozzi9
Skip locales not used in any product channels (#137)
7bdac13
lruozzi9 added a commit that referenced this issue Aug 3, 2022
@lruozzi9
Skip locales not used in any channels also for immutable slug value h…
d2f2ab4 
…andler (#137)
lruozzi9 added a commit that referenced this issue Aug 4, 2022
@lruozzi9
Skip locales not used in any product channels (#137)
b62d317
lruozzi9 added a commit that referenced this issue Aug 4, 2022
@lruozzi9
Skip locales not used in any channels also for immutable slug value h…
9bf52ec 
…andler (#137)
@mmenozzi
Copy link
Member

This is related to #148

@mmenozzi mmenozzi added this to the v2.0 milestone Aug 29, 2023
@mmenozzi mmenozzi mentioned this issue Sep 1, 2023
Merged
@lruozzi9 lruozzi9 linked a pull request Sep 1, 2023 that will close this issue
Validate product variant and its product before saving them (#148) #169
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmenozzi mmenozzi

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Validate product variant and its product before saving them (#148) webgriffe/SyliusAkeneoPlugin
2 participants
@mmenozzi @lruozzi9