Fix overwrite Content-Type test #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headers get set *after* Content-Type already got overwritten. Hence the test is not testing whether the Content-Type overwrite is actually skipped.
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 7 7
Lines 264 264
=======================================
Hits 256 256
Misses 8 8Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix for #377 (comment)
Did you add tests for your changes?
Yes, in test suite.
Summary
The headers get set after Content-Type already got overwritten. Hence
the test is not testing whether the Content-Type overwrite is actually
skipped.
Does this PR introduce a breaking change?
No
Other information