Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS runtime #1549

Merged
merged 13 commits into from
Nov 14, 2022
Merged

iOS runtime #1549

merged 13 commits into from
Nov 14, 2022

Conversation

Ma-Dan
Copy link
Contributor

@Ma-Dan Ma-Dan commented Nov 9, 2022

Sorry for the delayed PR, please review this version.

runtime/core/decoder/ios_asr_model.cc Outdated Show resolved Hide resolved
runtime/core/decoder/ios_asr_model.cc Outdated Show resolved Hide resolved
runtime/core/decoder/ios_asr_model.cc Outdated Show resolved Hide resolved
runtime/core/decoder/ios_asr_model.cc Outdated Show resolved Hide resolved
runtime/core/decoder/ios_asr_model.cc Outdated Show resolved Hide resolved
runtime/ios/WenetDemo/WenetDemo/wenet/wenet.h Show resolved Hide resolved
runtime/ios/WenetDemo/WenetDemo/wenet/wenet.mm Outdated Show resolved Hide resolved
runtime/ios/api Outdated Show resolved Hide resolved
runtime/ios/bin Outdated Show resolved Hide resolved
runtime/ios/websocket Outdated Show resolved Hide resolved
@pengzhendong
Copy link
Member

最后,还需要解决下述 lint 问题,并且写一个 README.md 描述用法。

@Ma-Dan
Copy link
Contributor Author

Ma-Dan commented Nov 10, 2022

目前还有如下几个问题:

  • 删除这些之后,需要处理的target少了很多,编译也节省了很多时间和空间,但是依然还剩下fst相关的6个execuatable target,关闭GRAPH_TOOLS后,这个手动处理已不再需要
  • swift 代码有相关 style 配置
  • lint

runtime/ios/README.md Outdated Show resolved Hide resolved
runtime/ios/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@pengzhendong pengzhendong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robin1001
Copy link
Collaborator

Great job! And I wonder if there is some video demo?

@robin1001 robin1001 merged commit d7fba09 into wenet-e2e:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants