CIF Related #1738
Merged
CIF Related #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin1001
reviewed
Mar 13, 2023
| @@ -0,0 +1,100 @@ | |||
| # Copyright (c) 2023 ASLP@NWPU (authors: He Wang, Fan Yu) | |||
There was a problem hiding this comment.
The embedding.py shares almost the same code with transformer/embedding.py, I think we can reuse it.
robin1001
reviewed
Mar 13, 2023
| @@ -0,0 +1,291 @@ | |||
| # Copyright (c) 2023 ASLP@NWPU (authors: He Wang, Fan Yu) | |||
There was a problem hiding this comment.
same as embedding.py, attention shares almost the same code as transformer/attention.py, and transformer/attention.py takes streamming into account.
robin1001
reviewed
Mar 13, 2023
| import numpy as np | ||
|
|
||
|
|
||
| def make_pad_mask(lengths: torch.Tensor, length_dim: int = -1, |
There was a problem hiding this comment.
this function is defined in utils/mask.py
robin1001
reviewed
Mar 13, 2023
| return mask | ||
|
|
||
|
|
||
| def sequence_mask(lengths, maxlen: Optional[int] = None, |
There was a problem hiding this comment.
this function is almost the same as subsequent_mask in utils/mask.py
robin1001
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the implementation of CIF-related code, including two types of Predictor and two types of CIF-Decoder. Meanwhile, four baseline experiments were conducted on the AISHELL dataset.