Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck for IDE #551

Merged
merged 6 commits into from
Jan 17, 2020
Merged

Typecheck for IDE #551

merged 6 commits into from
Jan 17, 2020

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 16, 2020

resolves #549

@antfu antfu changed the title Typecheck checkbox Typecheck for IDE Jan 16, 2020
@LingDong-
Copy link
Member

Great, thanks a lot!

BTW, Just thinking, perhaps we can do the autosaving only when the code terminates? Because I was running #550 's example which has an infinite loop in it. And the code is autosaved so even if I refresh the page it hangs forever. I had to clear cookies and restart chrome.

I don't have anything important stored on the IDE but for someone who does this could be a disaster :P

@antfu
Copy link
Member Author

antfu commented Jan 16, 2020

Or maybe let's not auto-run the user scripts on file open? And I think the iframe proposal in #545 can solve the infinite loop problem. (the IDE and the code execution is isolated, even if the code is dead, the ide will still function and able to do the force refresh for the code)

Conflicts:
	static/assets/js/ide.js
Conflicts:
	static/assets/js/ide.js
@antfu
Copy link
Member Author

antfu commented Jan 17, 2020

Resolved

@LingDong- LingDong- merged commit bae630d into wenyan-lang:master Jan 17, 2020
@antfu antfu mentioned this pull request Jan 17, 2020
LingDong- added a commit that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE should allow compile code snippet which has undefined variables
2 participants