This repository has been archived by the owner on Jun 4, 2023. It is now read-only.
fix: print menu button #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't need a print to PDF option at this moment. |
|
@manfromarce You can remove the save to pdf option, I will solve it similarly as Chrome does it but later. But thanks for fixing the print button. |
|
Ok, I removed the print to PDF option. |
|
recheckcla |
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Print button in main menu does nothing, instead the context menu button works. This PR should fix the issue and also adds Print as PDF with default Electron options (marginsType: 0, printBackground: false, printSelectionOnly: false, landscape: false)