This repository has been archived by the owner on Jun 4, 2023. It is now read-only.
Add zoom dialog #436
Merged
Add zoom dialog #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Currently not doing anything)
CLA Assistant Lite:Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format. |
|
I have read the CLA Document and I hereby sign the CLA. |
sentialx
reviewed
Apr 23, 2020
| @@ -321,6 +350,16 @@ export const Toolbar = observer(() => { | |||
| {hasCredentials && ( | |||
| <ToolbarButton icon={ICON_KEY} size={16} onClick={onKeyClick} /> | |||
| )} | |||
| {store.zoomFactor != 1 && ( | |||
There was a problem hiding this comment.
Suggested change
| {store.zoomFactor != 1 && ( | |
| {store.zoomFactor !== 1 && ( |
sentialx
reviewed
Apr 23, 2020
|
Thanks for your PR! Overall LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a zoom dialog.
The dialog automatically opens when zooming and automatically closes when it is not in active use (not hovered over, 1.5s delay).
When the current zoom is not 100%, a magnify icon (either with a plus or minus in it) is shown in the toolbar (icons from materialdesignicons).
This was my first time working with electron and react, so please tell me if something does not look right in the code.