Simplify boolean condition in Functions class

Change-Id: If9b17ca8b69bf4651d9017553e48d13b463073a8
wikimedia · Aug 15, 2024 · fff1924 · fff1924
1 parent 87c7a57
commit fff1924
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.phpcs.xml b/.phpcs.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ruleset>
 	<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
-		<exclude name="Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence.MissingParentheses" />
 		<exclude name="Generic.NamingConventions.UpperCaseConstantName.ClassConstantNotUpperCase" />
 		<exclude name="Generic.PHP.NoSilencedErrors.Discouraged" />
 		<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate" />

diff --git a/lib/Less/Functions.php b/lib/Less/Functions.php
@@ -712,7 +712,7 @@ private function _minMax( $isMin, $args ) {
 				$unit = $currentUnified->unit->toString();
 			}
 
-			if ( $unit !== '' && !$unitStatic || $unit !== '' && $order[0]->unify()->unit->toString() === "" ) {
+			if ( ( $unit !== '' && !$unitStatic ) || ( $unit !== '' && $order[0]->unify()->unit->toString() === "" ) ) {
 				$unitStatic = $unit;
 			}