Fix for not assuming that origin position is 0,0,0 #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix will make the UGS fetch the first point from the controller and display it in the visualizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will make UGS use the current work position as the starting point and use it for rendering the gcode in in the visualizer.
Consider this GCode, it has no Z coordinate defined but is yet rendered with the center at Z0 without this fix.
If I were to run this when the Z-position was not zero, what is visualized is not what I get:
With these changes it will now properly visualize what is going to happen when running this gcode program:
Also fixes some of the problems in the autoleveler discussed in #1583