-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with packager installation if path is not repository root #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me!
Just have one question, are there any tests to ascertain if this works? Coz I was getting an error earlier which is what prompted me to make this PR. |
I'm also still encountering this issue. For documentation: https://github.com/aoijs/website/actions/runs/7152884666/job/19478704479 |
@Faf4a this has not been merged yet. Have you tried with this patch? Alternatively, I am using a completely custom deployment script which you can find here: https://github.com/samrith-s/concurrent-tasks/blob/main/.github/workflows/github-pages.yml |
Oh, must've overlooked that. Thanks. |
@natemoo-re Any update on this PR? |
I just ran into the same issue when someone added additional NPM projects to a monorepo. Would love for this to get merged. |
@Princesseuh I got an issue after this PR was merged. |
It's not released yet, it's just merged |
I see v1.0.4 release here and the last I try to run GitHub action it shows: Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'withastro/action@v1' (SHA:64c331d10da115fbaab6c13ceb8d64f06199a703)
Error: withastro/action/v1/action.yml (Line: 96, Col: 7): Unexpected value 'working-directory'
Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. withastro/action/v1/action.yml (Line: 96, Col: 7): Unexpected value 'working-directory'
at GitHub.DistributedTask.ObjectTemplating.TemplateValidationErrors.Check()
at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load withastro/action/v1/action.yml It's the lastest released. |
If you try to use this action with a
path
option specified other than.
, the action fails with the following message:This is because it tries to find a lock file in the root directory rather than in the directory specified in
path
. This PR aims to fix it.