Support shorthand for package-manager option
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: do not fail command if grep has not found any version
|
Fix #45 |
delucis
reviewed
Aug 5, 2024
action.yml
Outdated
| @@ -29,7 +29,7 @@ runs: | |||
| len=`echo $INPUT_PM | wc -c` | |||
| if [ $len -gt 1 ]; then | |||
| PACKAGE_MANAGER=$(echo "$INPUT_PM" | grep -o '^[^@]*') | |||
| VERSION=$(echo "$INPUT_PM" | grep -o '@.*' | sed 's/^@//') | |||
| VERSION=$(echo "$INPUT_PM" | grep -o '@.*' || true | sed 's/^@//') | |||
There was a problem hiding this comment.
Ran a quick test locally and this seems to change the output of this command.
# current command:
echo "pnpm@14.7.0" | grep -o '@.*' | sed 's/^@//'
# output:
14.7.0
# PR change:
echo "pnpm@14.7.0" | grep -o '@.*' || true | sed 's/^@//'
# output:
@14.7.0Grouping the central command does seem to work though:
Suggested change
| VERSION=$(echo "$INPUT_PM" | grep -o '@.*' || true | sed 's/^@//') | |
| VERSION=$(echo "$INPUT_PM" | (grep -o '@.*' || true) | sed 's/^@//') |
(Although I am 100% not a shell script expert so this may not be the correct fix)
There was a problem hiding this comment.
Oh, you're right
my command is equal to:
echo "pnpm@14.7.0" | grep -o '@.*' || { true | sed 's/^@//'; }
The proper command will be
echo "pnpm@14.7.0" | { grep -o '@.*' || true; } | sed 's/^@//'
Fix: proper grouping for grep
delucis
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Thanks @corporateuser — the updated command works for me locally 👍
delucis
changed the title
package-manager option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: do not fail command if grep has not found any version