-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alias use with hydration scripts #3376
Conversation
🦋 Changeset detectedLatest commit: b6ea17a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
...script, | ||
props: { ...script.props, 'astro-script': result._metadata.pathname + '/script-' + i }, | ||
}); | ||
return renderElement('script', script); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is not related to this change, just noticed that we were still adding these special attributes. They were used by the legacy build system but are not needed any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice—looks great!
* Support alias use with hydration scripts * Adds a changeset * Updated lockfile
I saw this PR got a revalidate flag so I thought I might as well comment here. The start of the implementation that I couldn't finish: added a |
* Support alias use with hydration scripts * Adds a changeset * Updated lockfile
* test: remove it.only * test: skip failure until withastro#3376 is revisited
Changes
/@id
, an internal Vite resolution, unless it's already/@fs
.Testing
Test added
Docs
N/A, bug fix.