Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor static build config merge #4344

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Refactor static build config merge #4344

merged 3 commits into from
Aug 17, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 16, 2022

Changes

Refactor Vite config merging for static build and remove TODO.

vite.mergeConfig is not used as we want control ordering in some fields, e.g. plugins and rollupOptions

Testing

Should work with pnpm test

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022

🦋 Changeset detected

Latest commit: cd679af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 16, 2022
@natemoo-re natemoo-re linked an issue Aug 16, 2022 that may be closed by this pull request
1 task
@bluwy bluwy merged commit 500332a into main Aug 17, 2022
@bluwy bluwy deleted the refactor-build-config branch August 17, 2022 15:24
This was referenced Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite.assetsInclude is not working on astro build
2 participants