Fallback to undefined rather than false when resolving CLI flags

[joseph-lozano]

Changes

• If a user did not set their CLI to --draft, then typeof flags.drafts === 'boolean' will not be true, which would cause the drafts config to be set to false, overriding user configuration.

Testing

I was unable to run pnpm install on my machine. Any additional commits to add tests (or even pointing me the right direction to add them myself) would be very much appreciated.

I tested that this fix solves the issue by fiddling with dist/core/config.js on my own project.

Docs

This actually makes the behavior of astro build conform to the current documentation: https://docs.astro.build/en/guides/markdown-content/#markdown-drafts

[changeset-bot]

🦋 Changeset detected

Latest commit: f6aa568

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
astro	Patch
@e2e/astro-component	Patch
@e2e/error-react-spectrum	Patch
@e2e/error-sass	Patch
@e2e/errors	Patch
@e2e/lit-component	Patch
@e2e/preact-component	Patch
@e2e/react-component	Patch
@e2e/solid-component	Patch
@e2e/solid-recurse	Patch
@e2e/svelte-component	Patch
@e2e/e2e-tailwindcss	Patch
@e2e/ts-resolution	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[joseph-lozano]

⚠️ No Changeset found

I was unable to get pnpm install (and therefore pnpm exec changeset) to work on my computer. Unsure how I should proceed.

[bluwy]

This make sense to me. Otherwise it would always override at:

astro/packages/astro/src/core/config.ts

Line 375 in 1de82f0

if (typeof flags.drafts === 'boolean') astroConfig.markdown.drafts = flags.drafts;

Re pnpm i issue, what exact issues are you getting? We're happy to help if you're in the Astro discord server too!

I've added a changeset for this PR here.