Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly add react-dom alias to Vercel edge #4421

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Aug 22, 2022

Changes

Resolves #4391

Handle array and object signature in Vite aliases. This check was missing on the Vercel edge adapter, so react-dom was never aliased to something deno-ready!

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2022

🦋 Changeset detected

Latest commit: 408076f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 22, 2022
@bholmesdev bholmesdev merged commit 7820096 into main Aug 22, 2022
@bholmesdev bholmesdev deleted the fix/vercel-edge-react branch August 22, 2022 15:46
This was referenced Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel Edge Adapter fails to deploy if react integration is enabled
2 participants