Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vercel] Use Edge Functions instead of Edge Middlewares #4713

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Sep 10, 2022

Changes

Use Edge Functions instead of Edge Middlewares
https://discord.com/channels/830184174198718474/845451724738265138/1018069733603545122

We used to use middlewares because that was the way to access the Edge way back in April. Now, we should use normal functions.

This could be a breaking change for some people, should we bump to 1.1.0 or to 2.0.0?

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2022

🦋 Changeset detected

Latest commit: 3a34060

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/vercel Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 10, 2022
@matthewp
Copy link
Contributor

Yeah, we should probably make this a major. Will discuss with core next week. But we can release a prerelease in the mean time if it's needed.

@matthewp
Copy link
Contributor

We could avoid a major by making it an option and having middleware remain the default. I don't think it's a good default so probably a major is the way to go.

@JuanM04 JuanM04 marked this pull request as ready for review September 10, 2022 22:36
@matthewp
Copy link
Contributor

@JuanM04 Talked to core and we want to make this a major change. So if you can change that in the changesets we can get this out. Thanks again!

@matthewp matthewp merged commit 16113c3 into main Sep 12, 2022
@matthewp matthewp deleted the vercel-adapter-fix branch September 12, 2022 18:40
@astrobot-houston astrobot-houston mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants