-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): add server.headers
typing
#5635
Conversation
🦋 Changeset detectedLatest commit: 7e90645 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1472382
to
388772f
Compare
388772f
to
e9782d9
Compare
CI is failing due to timeout or socket hangup. |
packages/astro/src/@types/astro.ts
Outdated
* @name server.headers | ||
* @typeraw {OutgoingHttpHeaders} | ||
* @default `{}` | ||
* @version 1.70.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @version 1.70.0 | |
* @version 1.7.0 |
Just checking on this. (also in line 328)
@sarah11918 Looks like your commented line has been updated. Just need docs approval for this. |
@matthewp Docs approved! |
Changes
Added
server.headers
typing.This is needed to use
server.headers
along withdefineConfig
.Testing
I'm sorry but I couldn't figure out how to add TS test so no tests were added.
Docs
I'm not sure about docs generation.
/cc @withastro/maintainers-docs for feedback!