Fix polyfills not being available to imports on Netlify #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be2b777 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
Princesseuh
changed the title
natemoo-re
approved these changes
Feb 3, 2023
bluwy
reviewed
Feb 3, 2023
bluwy
reviewed
Feb 3, 2023
github-actions
bot
added
the
pkg: astro
natemoo-re
reviewed
Feb 6, 2023
matthewp
reviewed
Feb 6, 2023
natemoo-re
approved these changes
Feb 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously, we'd always externalize SSR adapters, kinda as a coincidence more than a need, but we did. This made it so our import was always first in the end bundle, in turn making it so our polyfills were always applied in time. Adding
astroas a peer deps of the adapters broke this, as they're now getting bundled.This PR adds an escape hatch for packages to mark themselves as needing external, despite triggering the heuristics to mark Astro-related packages as not-external
Fix #5996
Testing
Tested manually. I tried adding a test for this for almost 2 hours and couldn't figure it out, because of the monorepo the deps works differently in a way that Vite don't see them correctly and it was super annoying,
Docs
N/A, bug fix