Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mod devices CV port #35

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

ctsexton
Copy link
Collaborator

@ctsexton ctsexton commented Aug 1, 2023

Mod devices define their own sub class of CVPort here: https://moddevices.github.io/mod-sdk/mod/#CVPort

This makes it possible to load plugins like Cardinal that define the mod CVPort. That plugin actually lists both the lv2:CVPort and mod:CVPort in the manifest file:

    [
        a lv2:InputPort, lv2:CVPort, mod:CVPort ;
        lv2:index 8 ;
        lv2:symbol "lv2_cv_in_1" ;
        lv2:name "CV Input 1" ;
        lv2:minimum 0.0 ;
        lv2:maximum 10.0 ;
        lv2:portProperty lv2:connectionOptional;
    ]

Perhaps there is an alternative way to accept plugins like this since at least one of the port properties matches the accepted port types? I imagine there could be many more plugins like this that define their own port subclasses but which are entirely compatible with livi.

@wmedrano wmedrano merged commit 9ffcecb into wmedrano:main Oct 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants