Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jquery pluginizing (and general extendibility) #6

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

zzolo
Copy link

@zzolo zzolo commented Jan 2, 2013

Awesome work on this timeline and thanks for sharing your work.

We used it on a project recently and I had a few extra hours, so I spent time making this into a more extendable, reusable jQuery plugin.

You can see the options here:
https://github.com/MinnPost/jquery-vertical-timeline
And see an example here:
http://minnpost.github.com/jquery-vertical-timeline/example.html

This is a really big pull request and probably not something you want to pull in, but I wanted to show it to you all and see if you wanted to try to merge it all together. Feel free to close if you don't think this is a good direction.

@jkeefe
Copy link
Contributor

jkeefe commented Jan 4, 2013

Wow, Alan! This looks pretty cool! We're in the middle of a big project at
the moment, but I'm copying the team and we'll definitely take a look.
Really excited to see what you've done.

All the best,
John Keefe / WNYC

On Wed, Jan 2, 2013 at 5:11 PM, Alan Palazzolo notifications@github.mirror.nvdadr.comwrote:

Awesome work on this timeline and thanks for sharing your work.

We used it on a project recently and I had a few extra hours, so I spent
time making this into a more extendable, reusable jQuery plugin.

You can see the options here:
https://github.com/MinnPost/jquery-vertical-timeline
And see an example here:
http://minnpost.github.com/jquery-vertical-timeline/example.html

This is a really big pull request and probably not something you want to
pull in, but I wanted to show it to you all and see if you wanted to try to
merge it all together. Feel free to close if you don't think this is a good

direction.

You can merge this Pull Request by running:

git pull https://github.com/MinnPost/jquery-vertical-timeline jquery-pluginizing

Or view, comment on, or merge it at:

https://github.com/balancemedia/Timeline/pull/6
Commit Summary

  • More standardized JS libraries.
  • Moving index to example.
  • Removing unneeded js files.
  • Renaming main JS file.
  • Pearing down example file.
  • Moving images with CSS.
  • Changing reference to images.
  • Bringing in changes from our timeline project.
  • Adding group by year function.
  • Pearing down CSS.
  • Abstracting out markup for timeline.
  • Putting marker and post templates in JS.
  • Renaming to something a little more specific.
  • Turning into basic jQuery plugin.
  • Taking out IDs.
  • remove call for loading message.
  • Changing jquery selecting calls to use current context.
  • CSS namespacing each timeline instance so not to interfere with
    other…
  • Fixing use of remote images to local.
  • Ran CSS through beautifier.
  • Centering timeline in container.
  • Adding another example.
  • Adding custom column mapping.
  • Updating README.
  • Adding options to readme.
  • Minor tweak to README.

File Changes

  • M README.md (114)
  • A css/img/button-up-down-arrow.png (0)
  • A css/img/down-arrows.png (0)
  • A css/img/icon-link.png (0)
  • A css/img/icon-share.png (0)
  • A css/img/popup.png (0)
  • A css/img/tab-left.png (0)
  • A css/img/tab-right.png (0)
  • A css/img/up-arrows.png (0)
  • M css/style.css (799)
  • A example.html (51)
  • D index.html (104)
  • D js/handlebars.js (1550)
  • A js/jquery-veritcal-timeline.js (417)
  • A js/libs/handlebars-1.0.rc.1.min.js (3)
  • D js/libs/jquery-1.7.1.js (9266)
  • A js/libs/jquery.ba-resize.v1.1.min.js (9)
  • A js/libs/jquery.imagesloaded.v2.1.0.min.js (3)
  • A js/libs/jquery.isotope.v1.5.21.min.js (11)
  • D js/libs/modernizr-2.5.3.min.js (4)
  • A js/libs/tabletop.master-20121204.min.js (1)
  • D js/plugins.js (36)
  • D js/script.js (269)
  • D js/tabletop.js (300)

Patch Links

@emptymalei
Copy link

Hi, @zzolo , thank you for this great work.

I have a question. What if my data is really large? Will it be a problem for the browser to deal with too many items?

Thank you for your time. I am a newbie.

@zzolo
Copy link
Author

zzolo commented Jan 4, 2013

Hi @emptymalei, this is more of a general question about Google Docs and not necessarily about this tool.

I have found there to be limitations with the amount of data that can be handled by Google Docs. We had some issues with a few thousand rows of about 10 columns. I have not found any documentation on it, so I don't really have any actual set limits. I think it just comes down to trial an error.

Of course, there is always limitations on the clients browser concerning how much data can be processed and rendered regardless of these tools.

@emptymalei
Copy link

Thank you @zzolo . If the limitations are several thousand rows, I think it won't be a problem for most people. Maybe we can use json or xml instead if our data becomes really large.

@chrislkeller
Copy link

Per @emptymalei's suggestion, a config option to choose between pulling data via tabletop - breaking news situations - or flat json file for maintaining after the fact -- would be huge... Gonna check this out regardless... Nice work...

@zzolo
Copy link
Author

zzolo commented Feb 14, 2013

You can now just use your JS data directly. There is a data option. See the README. Also, you should use the projects issue queue for feature requests like this. :)

@zzolo
Copy link
Author

zzolo commented May 7, 2013

Wanted to ping on this issue. I talked briefly with Steve and John from WNYC about this, and just wanted to see if its still a possibility of putting all these changes back up stream here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants