spelling and grammatical error #550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bozzie-cmd
reviewed
Oct 1, 2020
| @@ -214,7 +214,7 @@ There are also some built in 'views' that will create a special column. For exa | |||
|
|
|||
| { view: "increment" , label: false , text: "+" } | |||
|
|
|||
| will have a link that increments the quantity. Setting the `label:false` will hide the label for the view. You can specify the text of the link with that `text:` attribute. | |||
| will have a link that increase the quantity. Setting the `label:false` will hide the label for the view. You can specify the text of the link with that `text:` attribute. | |||
There was a problem hiding this comment.
Firstly, this is not a correction of spelling OR grammar. You have actually MADE a grammar error in your poor attempt at correction, and shown a lack of understanding.
"Increments" is correct. While you could substitute "increases" for some loss of domain specific meaning, you cannot substitute "increase" which is grammatically INCORRECT.
Trivial PRs like this can be annoying, but when they are wrong, they are more than annoying. If you want to correct someone's English, make sure you know enough to do so!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.