Feature/#11 display processing errors #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kie and js-errors reports
wiiitek
reviewed
Oct 14, 2016
| var service = { | ||
| getMetadata: getMetadata, | ||
| saveMetadata: saveMetadata | ||
| }, | ||
| requestParams = requestParametersService.get(), | ||
| configParams = configService.getConfig(); | ||
| getEndpointUrl = endpointConfiguration.getEndpointUrl(); |
There was a problem hiding this comment.
Could we rename getEndpointUrl variable? To sth like
metadataUrlendpoint- ??
wiiitek
reviewed
Oct 14, 2016
| 'use strict'; | ||
| angularAMD.factory('endpointConfiguration', function () { | ||
| return { | ||
| getEndpointUrl: function () { |
There was a problem hiding this comment.
As service is called endpointConfiguration~maybe method could be renmd togetUrl` ?
What do you think?
There was a problem hiding this comment.
Yes, this is good idea - I renamed method to getEndpoint and production to getUrl.
…ndable panel directive
…-performance-report fix for client side performance report
…atterns fix for accepting patterns on localhost:9000
…mment-popover fix for included comment popover
…or-filtering Status filter renamed and fix for filtering
Search filter for test renamed
Css for url tabs
|
For the source comparator there is a JavaScript error as Angular expects JSON object but artifactId is a HTML source. This should probably be investigated... |
fix for tabs buttons being scrolled away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is for #11 - processing errors are now displayed on report tabs.
I hereby agree to the terms of the AET Contributor License Agreement.