Feature/sidepanel resize #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakublamprecht
requested review from
mateuszluczak,
michaldziubek,
wiiitek,
malaskowski and
edworczak
| var $content = $('.main'); | ||
| var $sidepanel = $('.aside'); | ||
|
|
||
| var isSidepanelResized = false; |
There was a problem hiding this comment.
Move consts outside link function
mateuszluczak
suggested changes
Feb 13, 2018
|
|
||
| function linkFunc($scope, $element) { | ||
| var $body = $('body'); | ||
| var $content = $('.main'); |
There was a problem hiding this comment.
Is there a better way of getting that elements? Can't the directive be attached to higher element in DOM and use elements in it's scope?
| @@ -22,6 +22,8 @@ define(['angularAMD'], function (angularAMD) { | |||
| ['$rootScope', 'localStorageService', ToggleSidepanelDirective]); | |||
|
|
|||
| function ToggleSidepanelDirective($rootScope, localStorageService) { | |||
| var $content = $('.main'); | |||
There was a problem hiding this comment.
This is also duplicated in the second directive, there should be a way of making that in single place
wiiitek
approved these changes
Feb 16, 2018
| $sidepanel.css('left', 0); | ||
|
|
||
| $(window).on('resize', onWindowResize); |
| localStorageService.put(EXPANDED_SIDEBAR_KEY_NAME, true); | ||
| } | ||
|
|
||
| function close() { | ||
| $content.css('left', 0); | ||
| $content.css('width', $body.width()); | ||
| $content.css('width', '100%'); |
There was a problem hiding this comment.
Can't we just remove width then?
There was a problem hiding this comment.
Yup, removed width inline style instead
added 2 commits
February 26, 2018 17:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added possibility of resizing sidepanel and updated sidepanel toggle functionality to work correctly with different widths of sidepanel
Motivation and Context
Test names can get pretty long and are hard to read with current width of the sidepanel.
Screenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.