Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new regex param sourcePattern to js errors data filter. #401

Merged
merged 4 commits into from
Oct 24, 2018
Merged

Add new regex param sourcePattern to js errors data filter. #401

merged 4 commits into from
Oct 24, 2018

Conversation

Jakub-Izbicki
Copy link
Contributor

Description

Basically adds new param that allows filtering js errors source by regex.

Motivation and Context

Fixed #356

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

@tkaik tkaik merged commit 0d8f5ae into master Oct 24, 2018
@tkaik tkaik deleted the feature/js-errors-source-filter branch October 24, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkaik tkaik tkaik approved these changes

@malaskowski malaskowski malaskowski approved these changes

@plutasnyy plutasnyy plutasnyy approved these changes

@ernestosiak ernestosiak Awaiting requested review from ernestosiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement sourcePattern attribute in JS Errors Data Filter
4 participants
@Jakub-Izbicki @tkaik @malaskowski @plutasnyy