Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/view source url #409

Merged
merged 5 commits into from
Oct 24, 2018
Merged

Bugfix/view source url #409

merged 5 commits into from
Oct 24, 2018

Conversation

ernestosiak
Copy link
Contributor

@ernestosiak ernestosiak commented Oct 22, 2018

When user clicks the "View source" url, artifact will be provided as a text/plain resource.

Description

Artifact is always served with "real" content type. Added additional parameter that user can use to specify desired content type.

Motivation and Context

Issue 370

Screenshots (if appropriate):

2018-10-22_13h42_29
2018-10-22_13h44_15

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

Copy link
Contributor

@wiiitek wiiitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

Copy link
Contributor

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update changelog.

@ernestosiak
Copy link
Contributor Author

changelog updated

@tkaik tkaik merged commit 89d8db4 into master Oct 24, 2018
@tkaik tkaik deleted the bugfix/view-source-url branch October 24, 2018 13:42
@tkaik tkaik mentioned this pull request Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants