Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added daily log rotation with 7 days retention #511

Merged
merged 5 commits into from
Aug 6, 2020
Merged

Added daily log rotation with 7 days retention #511

merged 5 commits into from
Aug 6, 2020

Conversation

maciejmalycha
Copy link
Contributor

Description

  • Logs are rotated daily
  • Rotated logs have date in the filename
  • Logs are compressed
  • Logs are removed after 7 days

Motivation and Context

Current short logs timespan of ~5 hours prevents effective logs collection and debugging of issues.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@maciejmalycha maciejmalycha requested a review from tkaik June 4, 2019 08:50
tkaik
tkaik approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@tkaik tkaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add entry in CHANGELOG.md file ("Unreleased" section) about this PR

@tMaxx tMaxx merged commit 62b3e3f into wttech:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkaik tkaik tkaik approved these changes

@dzuma dzuma dzuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maciejmalycha @tkaik @dzuma @tMaxx