Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs styling issue #72

Merged
merged 5 commits into from
Mar 10, 2017
Merged

Tabs styling issue #72

merged 5 commits into from
Mar 10, 2017

Conversation

agul89
Copy link
Contributor

@agul89 agul89 commented Mar 7, 2017

Modified the structure and styling to be more flexible and adjustable.
I hereby agree to the terms of the AET Contributor License Agreement.

@@ -55,9 +50,8 @@
}

&-link {
width: calc(100% - 200px);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@include at the top of the rest properties

float: right;

display: flex;
flex-wrap: nowrap;
&.is-absolute {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line above as it was before - follow the convention

@@ -17,7 +17,7 @@
limitations under the License.

-->
<div class="main page-main">
<div class="page-main">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'main' is also used with 'toolbar-holder', so expanding and collapsing works properly

Copy link

@mateuszluczak mateuszluczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@@ -309,19 +309,6 @@ ul {
}
}
}
.bg-shield {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up! 👍

@subiron subiron merged commit cc1be1d into master Mar 10, 2017
@malaskowski malaskowski deleted the tabs-styling-issue branch April 12, 2017 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants