Move custom meta content above licence in footer #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the custom meta content should be above the licence rather than underneath it. The examples in the design system samples show it[0] but it's not really covered by the official documentation[1] (which was what the library was based on in the early days) [0] https://govuk-frontend-review.herokuapp.com/components/footer [1] https://design-system.service.gov.uk/components/footer/
✅ Deploy Preview for govuk-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
peteryates
force-pushed
the
move-custom-meta-above-licence-in-footer
branch
from
a7e2747
to
ee6e044
Compare
guide/lib/examples/footer_helpers.rb
Outdated
| | Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam | ||
| a porta purus. Fusce faucibus aliquam massa sed eleifend. | ||
| - footer.with_meta_html do | ||
| | Built with love by x-govuk. |
There was a problem hiding this comment.
Might be useful to show including a link in this example (which would need the govuk-footer__link applied); not sure what the correct way of doing that would be, off the top of my heading, but I guess using the govuk_link helper.
Suggested change
| | Built with love by x-govuk. | |
| | Built with love by X-GOVUK. |
There was a problem hiding this comment.
Good point. I think there's room for a #govuk_footer_link_to helper as the ones in the example don't have the govuk-link class.
|
Good spot! Think we can improve the example a little, but nothing more to add. |
Co-authored-by: paulrobertlloyd <me+git@paulrobertlloyd.com>
peteryates
force-pushed
the
move-custom-meta-above-licence-in-footer
branch
from
eb9414e
to
b975d8e
Compare
|
Ooh, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the custom meta content should be above the licence rather than underneath it.
The examples in the design system samples show it but it's not really covered by the official documentation (which was what the library was based on in the early days).