Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subtitleHtml to prevent escaping anchor tag in Artist albums view #429

Merged
merged 1 commit into from
May 6, 2021

Conversation

nagubal
Copy link

@nagubal nagubal commented Oct 31, 2020

See HTML artifacts in displaying album year #395

Album listing display issue xbmc#358
Use subtitleHtml to prevent escaping anchor tag
@arigit
Copy link
Contributor

arigit commented Apr 5, 2021

Hi @enen92, can this be merged for 19.1? this will close #358, #395 and all checks pass on master
Looking forward to this fix
Thanks!

@arigit
Copy link
Contributor

arigit commented Apr 5, 2021

@enen92 noting that PR #430 was against kodi:master and this one is against 18.x, the fix is exactly the same - can you please apply this patch to master? No point in backporting to 18.x at this point so maybe it would make sense to re-open #430 and close #429 (this one)

I have tested this change in BOTH Kodi 19.0 and 18.9 (rebuilding the addon, repackaging it with a new name and installing it) and it solves the issue)

arigit added a commit to arigit/chorus2 that referenced this pull request May 1, 2021
Album listing display issue xbmc#358
Use subtitleHtml to prevent escaping anchor tag

Original fix author/pull request: xbmc#429
@enen92
Copy link
Member

enen92 commented May 6, 2021

18.x is dead, no updates will be done to this version if kodi. I'll merge this just for the sake of it.

@enen92 enen92 merged commit c3e2dd9 into xbmc:18.x May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants