Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting extended ansi colors (16-255) #3601

Closed
Tyriar opened this issue Jan 10, 2022 · 3 comments · Fixed by #3905
Closed

Support setting extended ansi colors (16-255) #3601

Tyriar opened this issue Jan 10, 2022 · 3 comments · Fixed by #3905
Labels
area/api help wanted type/enhancement Features or improvements to existing features
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 10, 2022 •
edited
Loading

API proposal: ITheme.extendedAnsi: number[], which would encode colors from index 16 (but not necessarily all of them).

VS Code ask: microsoft/vscode#140235
@Tyriar Tyriar added type/enhancement Features or improvements to existing features help wanted area/api labels Jan 10, 2022
@Tyriar Tyriar mentioned this issue Jan 10, 2022
Open
@silamon silamon mentioned this issue Jul 18, 2022
Merged
@Tyriar Tyriar added this to the 4.20.0 milestone Jul 18, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 19, 2022
@Tyriar
Be more defensive when setting extended ansi colors
8b3f9ad 
Part of xtermjs#3601
@Tyriar Tyriar mentioned this issue Jul 19, 2022
Merged
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
@goenning
Copy link

goenning commented Oct 5, 2022

@Tyriar @silamon How do I use these colors? If I have extendedAnsi: [ '#dcdcdc' ], what should the space code be?

I thought it would: \x1b[1;255mHello World\x1b[0m but it didn't work. Thanks

@Tyriar
Copy link
Member Author

Tyriar commented Oct 5, 2022

@goenning for 256 color you want:

\x1b[38;5;<index>m

So replacing index with 17 I think is what you want there?

@goenning
Copy link

goenning commented Oct 6, 2022

That was it, thank you 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api help wanted type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Support setting extended ansi colors (16-255) silamon/xterm.js
2 participants
@goenning @Tyriar