Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal.select does not fire onSelectionChange #3804

Closed
Tyriar opened this issue May 13, 2022 · 0 comments · Fixed by #3805
Closed

Terminal.select does not fire onSelectionChange #3804

Tyriar opened this issue May 13, 2022 · 0 comments · Fixed by #3805
Assignees
@Tyriar
Labels
area/api type/bug Something is misbehaving
Milestone
4.19.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 13, 2022 •
edited
Loading

xterm.js/typings/xterm.d.ts

Line 1024 in 7b44238

select(column: number, row: number, length: number): void;

@Tyriar Tyriar added type/bug Something is misbehaving area/api labels May 13, 2022
@Tyriar Tyriar added this to the 4.19.0 milestone May 13, 2022
@Tyriar Tyriar self-assigned this May 13, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 13, 2022
@Tyriar
Fire onSelectionChange when Terminal.select is called
5d98304 
Fixes xtermjs#3804
@Tyriar Tyriar mentioned this issue May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/api type/bug Something is misbehaving
Projects
None yet
Milestone
4.19.0
Development

Successfully merging a pull request may close this issue.

Fire onSelectionChange when Terminal.select is called Tyriar/xterm.js
1 participant
@Tyriar