Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tsconfig.json target #4706

Closed
Tyriar opened this issue Aug 21, 2023 · 0 comments · Fixed by #4743
Closed

Upgrade tsconfig.json target #4706

Tyriar opened this issue Aug 21, 2023 · 0 comments · Fixed by #4743
Assignees
@Tyriar
Labels
area/build Regarding the build process area/performance type/debt Technical debt that could slow us down in the long run
Milestone
5.4.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 21, 2023

Currently we have a mix of es2015 and es6 which are quite old at this point. We should update considering the fact that we only truly support evergreen browsers (and node 16+ for xterm-headless, I'm not sure we mention that anywhere though).

The bulk of the work here is in validating that nothing is broken in a complex embedder like vscode.
@Tyriar Tyriar added area/build Regarding the build process area/performance help wanted type/debt Technical debt that could slow us down in the long run labels Aug 21, 2023
@Tyriar Tyriar mentioned this issue Aug 21, 2023
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 1, 2023
@Tyriar
Upgrade es6 -> es2021
ceef536 
This uses the recommended target for node 16 in tsconfig/bases.

Fixes xtermjs#4706
@Tyriar Tyriar mentioned this issue Sep 1, 2023
Merged
@Tyriar Tyriar self-assigned this Sep 1, 2023
@Tyriar Tyriar added this to the 5.3.0 milestone Sep 1, 2023
@Tyriar Tyriar removed the help wanted label Sep 1, 2023
@Tyriar Tyriar modified the milestones: 5.3.0, 5.4.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/build Regarding the build process area/performance type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
5.4.0
Development

Successfully merging a pull request may close this issue.

Upgrade es6 -> es2021 Tyriar/xterm.js
1 participant
@Tyriar