Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protection flag support #4098

Merged
merged 9 commits into from
Sep 12, 2022
Merged

protection flag support #4098

merged 9 commits into from
Sep 12, 2022

Conversation

jerch
Copy link
Member

@jerch jerch commented Sep 3, 2022

Fixes #3651.

TODO:

  • some unit tests
  • DECRQSS report
  • consolidate DECRQSS

@Tyriar Rewrote the PR, this time without additional work in InputHandler.print, so this should not impact normal print data flow at all. 💪

Sidenote: Due to changing DECRQSS into an InputHandler function with some inline definitions I could save >3kB on the package.

Edit: Also fixed some feature docs, thus the website should be re-deployed at some point (still on v4.14).

@jerch jerch marked this pull request as ready for review September 4, 2022 09:53
@jerch jerch mentioned this pull request Sep 4, 2022
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but looks good other than my clean up comment

src/common/InputHandler.ts Outdated Show resolved Hide resolved
@Tyriar Tyriar added this to the 5.0.0 milestone Sep 7, 2022
@Tyriar Tyriar merged commit d3fd3d0 into xtermjs:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full support for DECSED,DECSEL,DECSCA, etc for xtermjs
2 participants