Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link event listener leak #4342

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Fix link event listener leak #4342

merged 2 commits into from
Dec 20, 2022

Commits on Dec 20, 2022

  1. Fix link event listener leak 

    The bug here is that _clearCurrentLink was being called only on the
line(s) that changed, but _askForLink was then being triggered
regardless. This caused more onRenderedViewportChange listeners to be
registered and for the thread blocking to get exponentially worse.

Fixes xtermjs#4341
    @Tyriar
    Tyriar committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f28c21e View commit details
    Browse the repository at this point in the history

  2. Improve comment

    @Tyriar
    Tyriar committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    7b8ad8c View commit details
    Browse the repository at this point in the history