Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported interpreters to tox.ini #770

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jamim
Copy link

@Jamim Jamim commented Dec 2, 2023

Hello,

PyYAML declares support for a wide range of Python versions, but not all of them were included in the envlist at tox.ini, so I'd like to propose changes that:

  • add supported interpreters to tox.ini
  • enable the skip_missing_interpreters option
  • add {posargs} to the test command in order to provide flexibility, so you can pass arguments to pytest, e.g.: tox -- -k test_dump

With these changes, tox's outcome on my system looks like this:

  py313: OK (30.51=setup[21.49]+cmd[9.02] seconds)
  py312: OK (21.70=setup[11.32]+cmd[10.38] seconds)
  py311: OK (21.23=setup[11.13]+cmd[10.10] seconds)
  py310: OK (31.03=setup[17.04]+cmd[13.99] seconds)
  py39: OK (26.91=setup[13.03]+cmd[13.88] seconds)
  py38: OK (28.26=setup[12.68]+cmd[15.58] seconds)
  pypy310: OK (48.78=setup[24.57]+cmd[24.22] seconds)
  pypy39: OK (44.77=setup[18.24]+cmd[26.52] seconds)
  pypy38: SKIP (0.34 seconds)
  congratulations :) (253.70 seconds)

Best regards!

PyYAML declares supported for a wide range of Python versions,
but not all of them were included to the envlist at tox.ini.

These changes also:
  * enable the skip_missing_interpreters option
  * add {posargs} to the test command in order to provide flexibility,
    so you can pass arguments to pytest, e.g.: tox -- -k test_dump
@Jamim
Copy link
Author

Jamim commented Aug 6, 2024

Hello @nitzmahone,
While you are here, would you mind reviewing this PR?
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant