Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dependencies #4186

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Mar 5, 2022

What's the problem this PR addresses?

We have some unused dependencies that forces API consumers to waste resources on unused code.

How did you fix it?

Removed the unused dependencies.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner March 5, 2022 12:13
@arcanis arcanis force-pushed the master branch 2 times, most recently from b296f85 to c225c1f Compare March 7, 2022 23:36
@arcanis arcanis force-pushed the merceyz/chore/unused-dependencies branch from a7a4100 to f5fe35e Compare March 8, 2022 08:17
@arcanis arcanis merged commit fdcf423 into master Mar 8, 2022
@arcanis arcanis deleted the merceyz/chore/unused-dependencies branch March 8, 2022 10:48
merceyz added a commit that referenced this pull request Oct 21, 2023
* chore: remove unused dependencies

* chore(core): remove unused pnp dependency

* chore: remove more unused dependencies

* test: remove unused dependencies

* test: resolve setup file

(cherry picked from commit fdcf423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants