fix(nm): improves external soft links hoisting #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
reviewed
Mar 27, 2022
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
merceyz
approved these changes
Mar 27, 2022
merceyz
pushed a commit
that referenced
this pull request
May 12, 2022
* Improves portal hoisting * Move hasUnhoistedDependencies into a separate function * Updates test, removes debugging code * Adds support and a test for deep nested portals hoisting * Fixes test description * Lint * Update packages/yarnpkg-nm/sources/hoist.ts Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> * Update packages/yarnpkg-nm/sources/hoist.ts Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> * Lint Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
pilaoda
reviewed
Mar 19, 2023
| @@ -668,6 +684,9 @@ const hoistGraph = (tree: HoisterWorkTree, rootNodePath: Array<HoisterWorkTree>, | |||
| } | |||
| } | |||
|
|
|||
| if (parentNode.dependencyKind === HoisterDependencyKind.EXTERNAL_SOFT_LINK && wereNodesHoisted) | |||
There was a problem hiding this comment.
Why only EXTERNAL_SOFT_LINK need anotherRound? I meet a bug that parentNode is a sub workspace and could not hoist its dependencies.
There was a problem hiding this comment.
Please open an issue with a reproduction.
There was a problem hiding this comment.
#5332 here is the issue with a reproduction repo.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When all the dependencies were hoisted from nested portals the portals were not hoisted
Fixes: #4240
How did you fix it?
Applies additional hoisting rounds when external soft links run out of unhoisted dependencies
Checklist