Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nm): Adds a unit test which checks that two-branch circular graphs handled properly #4272

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

larixer
Copy link
Member

@larixer larixer commented Mar 26, 2022

What's the problem this PR addresses?

The second clause of this condition was not covered with unit, integration or E2E tests

if (!node.isHoistBorder && nextAliasedLocatorPath.indexOf(getAliasedLocator(node)) < 0) {

How did you fix it?

I have found a unit test that recreates the conditions when this clause is needed - it is a graph with two similar circular branches.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@larixer larixer requested a review from merceyz March 26, 2022 10:10
@merceyz merceyz enabled auto-merge (squash) March 26, 2022 18:13
@merceyz merceyz merged commit 9a5499c into master Mar 26, 2022
@merceyz merceyz deleted the larixer/two-circular-branches-graph-test branch March 26, 2022 20:07
merceyz pushed a commit that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants