perf(core): skip unnecessary access
call in fetchPackageFromCache
#4352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
During the link step of an install the
Cache
will check if cache entries exists on disk even though it already checked that during the fetch step.Ref #4057
How did you fix it?
Check if the cache entry is in
markedFiles
before checking the disk.Benchmark results
On the gatsby benchmark this removes 1942
access
syscallsChecklist