Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the "yarn up" command when the dependency doesnt need upgrades #4378

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fixes the "yarn up" command when the dependency doesnt need upgrades #4378

merged 2 commits into from
Apr 25, 2022

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Apr 19, 2022

What's the problem this PR addresses?

The yarn up command was broken when run on dependency already up-to-date since #4305.

How did you fix it?

Normalizes the descriptor before passing it to forgetResolution.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

merceyz
merceyz requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs a test

@arcanis arcanis requested a review from merceyz April 25, 2022 14:10
@arcanis arcanis merged commit fd0c527 into master Apr 25, 2022
@arcanis arcanis deleted the mael/up-fix-2 branch April 25, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcanis @merceyz