fix(fslib): fix return shape of promisified `fs.write` #4411

mhassan1 · 2022-04-28T15:16:09Z

What's the problem this PR addresses?
This PR fixes the return shape for promisified fs.write. Once readv and writev are implemented, those should get the same treatment.

How did you fix it?
This adds a promisified version of fs.write in patchFs, similar to what was done in #2128.

Checklist

I have read the Contributing Guide.
I have set the packages that need to be released for my changes to be effective.
I will check that all automated PR checks pass before the PR gets reviewed.

merceyz

LGTM!

* fix(fslib): fix return shape of promisified `fs.write` * chore: update hook * chore: versions Co-authored-by: merceyz <merceyz@users.noreply.github.com>

mhassan1 and others added 3 commits April 28, 2022 11:11

fix(fslib): fix return shape of promisified fs.write

0e89c3c

chore: update hook

e59e1a1

chore: versions

aec5a72

merceyz approved these changes Apr 28, 2022

View reviewed changes

merceyz merged commit 8f1ff59 into yarnpkg:master Apr 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(fslib): fix return shape of promisified `fs.write` #4411

fix(fslib): fix return shape of promisified `fs.write` #4411

mhassan1 commented Apr 28, 2022

merceyz left a comment

fix(fslib): fix return shape of promisified fs.write #4411

fix(fslib): fix return shape of promisified fs.write #4411

Conversation

mhassan1 commented Apr 28, 2022

merceyz left a comment

Choose a reason for hiding this comment

fix(fslib): fix return shape of promisified `fs.write` #4411

fix(fslib): fix return shape of promisified `fs.write` #4411